Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Migrate to actions/cache@v2 #1521

Closed
wants to merge 1 commit into from
Closed

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Dec 7, 2021

Why are the changes needed?

https://github.com/actions/cache

https://github.com/actions/cache/releases/tag/v2.0.0

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793 pan3793 changed the title Migrate to actions/cache@v2 [BUILD] Migrate to actions/cache@v2 Dec 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1521 (87cad57) into master (627d66b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1521      +/-   ##
============================================
- Coverage     59.22%   59.21%   -0.02%     
  Complexity      172      172              
============================================
  Files           241      241              
  Lines         12192    12192              
  Branches       1496     1496              
============================================
- Hits           7221     7219       -2     
- Misses         4358     4359       +1     
- Partials        613      614       +1     
Impacted Files Coverage Δ
...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala 89.47% <0.00%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627d66b...87cad57. Read the comment docs.

@ulysses-you
Copy link
Contributor

thanks, merging to master

@ulysses-you ulysses-you added this to the 1.5.0 milestone Dec 7, 2021
@pan3793 pan3793 deleted the ga-cache branch December 7, 2021 11:24
pan3793 added a commit that referenced this pull request Dec 7, 2021
### _Why are the changes needed?_

https://github.com/actions/cache

https://github.com/actions/cache/releases/tag/v2.0.0

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1521 from pan3793/ga-cache.

Closes #1521

87cad57 [Cheng Pan] Migrate to actions/cache@v2

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: ulysses-you <[email protected]>
@pan3793 pan3793 modified the milestones: 1.5.0, v1.4.1 Dec 7, 2021
@pan3793
Copy link
Member Author

pan3793 commented Dec 7, 2021

cherry picked to branch-1.4 to make cache consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants