Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Switch to setup-java@v2 #1520

Closed
wants to merge 2 commits into from
Closed

[BUILD] Switch to setup-java@v2 #1520

wants to merge 2 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Dec 7, 2021

Why are the changes needed?

Migrate to GA setup-java from v1 to v2

https://github.com/actions/setup-java

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #1520 (7aad9d2) into master (6ea83e0) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1520      +/-   ##
============================================
- Coverage     59.22%   59.21%   -0.01%     
  Complexity      172      172              
============================================
  Files           241      241              
  Lines         12182    12182              
  Branches       1494     1494              
============================================
- Hits           7215     7214       -1     
  Misses         4356     4356              
- Partials        611      612       +1     
Impacted Files Coverage Δ
...ache/kyuubi/operation/KyuubiOperationManager.scala 81.57% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea83e0...7aad9d2. Read the comment docs.

@pan3793 pan3793 self-assigned this Dec 7, 2021
@pan3793 pan3793 added the infra label Dec 7, 2021
@pan3793 pan3793 added this to the 1.5.0 milestone Dec 7, 2021
@pan3793
Copy link
Member Author

pan3793 commented Dec 7, 2021

Thanks, merging to master

@pan3793 pan3793 closed this in 627d66b Dec 7, 2021
@pan3793 pan3793 deleted the ga branch December 7, 2021 08:36
pan3793 added a commit that referenced this pull request Dec 7, 2021
### _Why are the changes needed?_

Migrate to GA setup-java from v1 to v2

https://github.com/actions/setup-java

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1520 from pan3793/ga.

Closes #1520

7aad9d2 [Cheng Pan] nit
5b31242 [Cheng Pan] Use setup-java@v2

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
@pan3793 pan3793 modified the milestones: 1.5.0, v1.4.1 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants