-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Reduce unnecessary maven profile #1257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1257 +/- ##
============================================
+ Coverage 73.10% 78.22% +5.11%
- Complexity 41 110 +69
============================================
Files 175 177 +2
Lines 6846 6940 +94
Branches 835 852 +17
============================================
+ Hits 5005 5429 +424
+ Misses 1441 1043 -398
- Partials 400 468 +68
Continue to review full report at Codecov.
|
Copy the comment or make a summary here in PR desc? |
...nsion-spark-common/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala
Outdated
Show resolved
Hide resolved
./build/mvn clean deploy -DskipTests -Pkyuubi-extension-spark-3-1,spark-provided -s ./build/release/asf-settings.xml | ||
./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided | ||
./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-3.1 -s ./build/release/asf-settings.xml -pl dev/kyuubi-extension-spark-3-1 -am | ||
./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-3.2 -s ./build/release/asf-settings.xml -pl dev/kyuubi-extension-spark-3-2 -am |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L39: build against the default spark version, publish no kyuubi spark extension modules
L40: only build kyuubi-extension-spark-3-1
and dependent modules against spark 3.1, publish kyuubi-extension-spark-3-1
L41: only build kyuubi-extension-spark-3-2
and dependent modules against spark 3.2, publish kyuubi-extension-spark-3-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it allowed if we release the binary that contains Spark binary ? before we only release Kyuubi without Spark.
-pl dev/kyuubi-extension-spark-3-1 -am | ||
${KYUUBI_DIR}/build/mvn clean deploy -DskipTests -Papache-release,spark-3.2 \ | ||
-s "${KYUUBI_DIR}/build/release/asf-settings.xml" \ | ||
-pl dev/kyuubi-extension-spark-3-2 -am |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as GA
cc @yaooqinn @ulysses-you all comments have been addressed, please review again. |
thanks, merging to master |
Why are the changes needed?
The changes based on #1226 (comment)
In this PR, I'm going to remove profiles
kyuubi-extension-spark-3-1
andkyuubi-extension-spark-3-2
, and keepspark-3.0
,spark-3.1
,spark-3.2
.After changes, when
spark-3.1
is active, setspark.version
to 3.1.2 and enablekyuubi-extension-spark-common
module andkyuubi-extension-spark-3-1
module,spark-3.2
does the same thingHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request