-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK][MEDIUM] Setup GitHub Actions for Kyuubi Python client (former PyHive) #6281
Comments
I can help, please assign this PR to me |
@sudohainguyen thanks, assigned. And you are welcome to improve this new Python module~ |
@sudohainguyen hi, do you have any progress on this task? |
working on it @pan3793 |
update: since most of the tasks were running on outdated Python versions and components versions including trino, presto, etc.., think we should implement entirely different ones |
@sudohainguyen thanks for updating, starting from Python 3.9 and 3.10 SGTM |
# 🔍 Description ## Issue References 🔗 This pull request fixes #6281 Following up to #6343 , this PR adds `pytest-xdist` plugin to speed up python client unit testing ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Running tests usually takes ~10 mins #### Behavior With This Pull Request 🎉 Running tests can take up to 5 mins #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6369 from sudohainguyen/ci/speed-up-test. Closes #6281 f0ce557 [Harry] [KYUUBI #6281][PY] Speed up testing with xdist plugin Authored-by: Harry <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
# 🔍 Description ## Issue References 🔗 This pull request enables running hive test cases in python client, however there's one trivial case not covered yet and two others require a proper container setup ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Hive test disabled in #6343 #### Behavior With This Pull Request 🎉 Can cover hive test cases #### Related Unit Tests No --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6381 from sudohainguyen/ci/hive. Closes #6281 a861382 [Harry] [KYUUBI #6281][PY] Enable hive test in python client Authored-by: Harry <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
What's the level of this task?
MEDIUM
Code of Conduct
Search before creating
Mentor
Skill requirements
Background and Goals
PyHive has been donated to Apache Kyuubi, the codebase was imported into main repo under
./python
, previously, it used Travis for CI, now, we should migrate the workflow to GitHub Actions.https://incubator.apache.org/ip-clearance/kyuubi-pyhive.html
Implementation steps
Additional context
Introduction of 2024H1 Kyuubi Code Contribution Program
The text was updated successfully, but these errors were encountered: