Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Upload Test Log for CI failure shall contain trino engine log #2094

Closed
2 of 3 tasks
yaooqinn opened this issue Mar 10, 2022 · 1 comment
Closed
2 of 3 tasks

[CI] Upload Test Log for CI failure shall contain trino engine log #2094

yaooqinn opened this issue Mar 10, 2022 · 1 comment
Assignees
@zhaomin1423
Labels
good first issue beginner skills required help wanted
Milestone
v1.6.0

Comments

@yaooqinn
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

https://github.com/apache/incubator-kyuubi/blob/master/.github/workflows/master.yml#L93

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@yaooqinn yaooqinn added this to the v1.6.0 milestone Mar 10, 2022
@yaooqinn yaooqinn added good first issue beginner skills required help wanted labels Mar 10, 2022
@zhaomin1423
Copy link
Member

I am willing to do it.

zhaomin1423 added a commit to zhaomin1423/kyuubi that referenced this issue Mar 10, 2022
@zhaomin1423
[CI] Upload Test Log for CI failure shall contain trino engine log ap…
5796174 
…ache#2094
yaooqinn pushed a commit that referenced this issue Mar 11, 2022
@zhaomin1423 @yaooqinn
[KYUUBI #2097] [CI] Upload Test Log for CI failure shall contain trin…
c5a7c66 
…o engine log #2094

### _Why are the changes needed?_

Upload Test Log for CI failure shall contain trino engine log.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2097 from zhaomin1423/update_ci.

Closes #2097

5796174 [Min Zhao] [CI] Upload Test Log for CI failure shall contain trino engine log #2094

Authored-by: Min Zhao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
wForget pushed a commit to wForget/kyuubi that referenced this issue Mar 11, 2022
@zhaomin1423 @wForget
[KYUUBI apache#2097] [CI] Upload Test Log for CI failure shall contai…
c7a5d3f 
…n trino engine log apache#2094

### _Why are the changes needed?_

Upload Test Log for CI failure shall contain trino engine log.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes apache#2097 from zhaomin1423/update_ci.

Closes apache#2097

5796174 [Min Zhao] [CI] Upload Test Log for CI failure shall contain trino engine log apache#2094

Authored-by: Min Zhao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaomin1423 zhaomin1423

Labels
good first issue beginner skills required help wanted
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@yaooqinn @zhaomin1423