Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUB-TASK][KPIP-2] Minor refactor OperationUtil #1839

Closed
3 tasks done
link3280 opened this issue Jan 25, 2022 · 1 comment
Closed
3 tasks done

[SUB-TASK][KPIP-2] Minor refactor OperationUtil #1839

link3280 opened this issue Jan 25, 2022 · 1 comment
Assignees
@link3280
Labels
kind:feature Feature request

Comments

@link3280
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Minor refactor OperationUtil for two reasons:

  • OperationUtil resides in result package and mainly creates result sets, thus ResultSetUtil may be a more proper name.
  • OperationUtil returns dynamic schema based on result data, but a static schema is more friendly for CLIs.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@link3280 link3280 added the kind:feature Feature request label Jan 25, 2022
@link3280
Copy link
Contributor Author

cc @yanghua

@yanghua yanghua mentioned this issue Jan 25, 2022
Closed
45 tasks
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Minor refactor OperationUtil
811d3a7
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Rename OperationUtil to ResultSetUtil
92a2e3b
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Rewrite ResultSetUtil using scala
20e29ad
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Rewrite ResultSetUtil using scala
d56a381
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Fix license match failure
f97ec73
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Rewrite ResultSetUtil using scala
98d4e03
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Rewrite ResultSetUtil using scala
48d611d
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Remove unused imports
7c36c5c
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 26, 2022
@link3280
[KYUUBI apache#1839] Improve docs and comments
a187a53
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 27, 2022
@link3280
[KYUUBI apache#1839] Improve docs and comments
b870427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@link3280 link3280

Labels
kind:feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@link3280