Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Disable nightly run on forked repos #1804

Closed
3 tasks done
link3280 opened this issue Jan 19, 2022 · 0 comments
Closed
3 tasks done

[Bug] Disable nightly run on forked repos #1804

link3280 opened this issue Jan 19, 2022 · 0 comments
Assignees
Milestone

Comments

@link3280
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

The nightly run should only be effective on the official repo.

Affects Version(s)

1.5.0

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@link3280 link3280 added the bug label Jan 19, 2022
@yaooqinn yaooqinn added this to the v1.5.0 milestone Jan 19, 2022
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 19, 2022
ulysses-you pushed a commit that referenced this issue Feb 8, 2022
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

```
Run docker/login-actionv[1](https://github.com/cfmcgrady/incubator-kyuubi/runs/5088959102?check_suite_focus=true#step:3:1)
  with:
    ecr: auto
    logout: true
Error: Username and password required
```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1863 from cfmcgrady/avoid-publish-image.

Closes #1804

5d7711b [Fu Chen] [GA] avoid push docker image for forked repos

Authored-by: Fu Chen <[email protected]>
Signed-off-by: ulysses-you <[email protected]>
ulysses-you pushed a commit that referenced this issue Feb 8, 2022
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

```
Run docker/login-actionv[1](https://github.com/cfmcgrady/incubator-kyuubi/runs/5088959102?check_suite_focus=true#step:3:1)
  with:
    ecr: auto
    logout: true
Error: Username and password required
```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1863 from cfmcgrady/avoid-publish-image.

Closes #1804

5d7711b [Fu Chen] [GA] avoid push docker image for forked repos

Authored-by: Fu Chen <[email protected]>
Signed-off-by: ulysses-you <[email protected]>
(cherry picked from commit 216560a)
Signed-off-by: ulysses-you <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants