Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUB-TASK][KPIP-2] Extend Flink ExecuteStatement to support more operations #1681

Closed
3 tasks done
link3280 opened this issue Jan 5, 2022 · 2 comments
Closed
3 tasks done
Assignees
Labels
kind:feature Feature request
Milestone

Comments

@link3280
Copy link
Contributor

link3280 commented Jan 5, 2022

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

ExecuteStatement of Flink engine now supports QueryOperation only. We can extend it to support more operations that Flink Executor already supports. e.g. ShowTableOperation,CreateTableOperation, ExplainOperation.

Motivation

This is a sub-task of KPIP-2 #1322 .

Describe the solution

Add a case matching before executing operations. Execute QueryOperation (which returns ResultDescriptor) via executor.executeQuery, while execute other operations (which returns TableResult) via executor.executeOperation.

There're several operations that executor.executeOperation doesn't support, such as SetOperation. We may address that afterward.

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@link3280 link3280 added the kind:feature Feature request label Jan 5, 2022
@yaooqinn yaooqinn added this to the v1.5.0 milestone Jan 5, 2022
@yanghua yanghua changed the title [FEATURE] Extend Flink ExecuteStatement to support more operations [SUB-TASK][KPIP-2] Extend Flink ExecuteStatement to support more operations Jan 5, 2022
@yanghua
Copy link
Contributor

yanghua commented Jan 5, 2022

@link3280 Thanks for opening this issue, it would be better to follow this issue prefix: [SUB-TASK][KPIP-2] for archiving the Flink SQL engine.

@link3280
Copy link
Contributor Author

link3280 commented Jan 5, 2022

@link3280 Thanks for opening this issue, it would be better to follow this issue prefix: [SUB-TASK][KPIP-2] for archiving the Flink SQL engine.

OK, I'll follow the pattern. Thanks for the reminder.

link3280 added a commit to link3280/kyuubi that referenced this issue Jan 7, 2022
link3280 added a commit to link3280/kyuubi that referenced this issue Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants