Skip to content

Commit

Permalink
Improve CI with cancel & concurrency
Browse files Browse the repository at this point in the history
  • Loading branch information
yaooqinn committed Mar 18, 2022
1 parent 494c3a8 commit 733df9c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
check-latest: false
- name: Maven install
run: >-
build/mvn -T 4 clean install -Pflink-provided,spark-provided
build/mvn clean install -Pflink-provided,spark-provided
-Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
-pl kyuubi-ctl,kyuubi-server,kyuubi-assembly -am
- name: Check dependency list
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ concurrency:
group: linter-${{ github.ref }}
cancel-in-progress: true

env:
MAVEN_OPTS: -Dorg.slf4j.simpleLogger.defaultLogLevel=error

# no install runs before style check because it is expensive, we can skip build if style fails
# Well, sometimes when we introduce a new module, it may 'fail' the style check for missing
# dependency we just create for other module to inherit.
Expand All @@ -55,9 +52,9 @@ jobs:
cache: 'maven'
check-latest: false
- name: Scalastyle with maven
run: build/mvn -T 4 scalastyle:check ${{ matrix.profiles }} -pl '!:kyuubi-codecov_2.12,!:kyuubi-assembly_2.12'
run: build/mvn scalastyle:check ${{ matrix.profiles }} -pl '!:kyuubi-codecov_2.12,!:kyuubi-assembly_2.12'
- name: Upload scalastyle report
if: failure()
run: for log in `find * -name "scalastyle-output.xml"`; do echo "=========$log========="; grep "error" $log; done
- name: JavaStyle with maven
run: build/mvn -T 4 spotless:check ${{ matrix.profiles }} -pl '!:kyuubi-codecov_2.12,!:kyuubi-assembly_2.12'
run: build/mvn spotless:check ${{ matrix.profiles }} -pl '!:kyuubi-codecov_2.12,!:kyuubi-assembly_2.12'

0 comments on commit 733df9c

Please sign in to comment.