feat(cmd): avoid to use CommandAttributes::flags directly #2619
Conversation
|
Is this to avoid not calling |
Exactly. |
|
What about making it private to avoid some explicit calling? ( Current method lgtm but I think it's easy to use it directly next time) |
Done. |
|
Also I plan to make key_range and other related members private in the next PR. |
| @@ -182,9 +228,11 @@ struct CommandAttributes { | |||
| // commander object generator | |||
| CommanderFactory factory; | |||
|
|
|||
| uint64_t InitialFlags() const { return flags_; } | |||
There was a problem hiding this comment.
Minor question: why InitialFlags() in some cases?
There was a problem hiding this comment.
Some times we cannot get the cmd args, so maybe the initial flags is useful. Also I currently don't want to touch some legacy sources.
| template <typename T> | ||
| auto MakeCmdAttr(const std::string &name, int arity, const std::string &description, NoKeyInThisCommand no_key, | ||
| const AdditionalFlagGen &flag_gen = {}) { | ||
| CommandAttributes attr(name, arity, CommandCategory::Unknown, ParseCommandFlags(description, name), flag_gen, no_key, |
There was a problem hiding this comment.
So NO_KEY has becoming a different ctor fn?
There was a problem hiding this comment.
Yeah, 0,0,0 is not clear enough.
|
We should use
CommandAttributes::GenerateFlagsinstead of accessing theflagsmember directly.