KAFKA-15561 [1/N]: Introduce new subscribe api for RE2J regex #17897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianetm
commented
Nov 21, 2024
| @@ -143,6 +143,16 @@ public synchronized void subscribe(Pattern pattern) { | |||
| subscribe(pattern, Optional.empty()); | |||
| } | |||
|
|
|||
| @Override | |||
| public void subscribe(SubscriptionPattern pattern, ConsumerRebalanceListener callback) { | |||
| throw new UnsupportedOperationException("Subscribe to RE2/J regular expression not supported in MockConsumer yet"); | |||
There was a problem hiding this comment.
note: support in MockConsumer will come in follow-up PR
dajac
reviewed
Nov 22, 2024
clients/src/main/java/org/apache/kafka/clients/consumer/SubscriptionPattern.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/SubscriptionPattern.java
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java
Show resolved
Hide resolved
|
Thanks @dajac, all comments addressed. |
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…#17897) Reviewers: David Jacot <[email protected]>
3 tasks
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…#17897) Reviewers: David Jacot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client support for consumer.subscribe with SubscriptionPattern (RE2/J pattern), as proposed on KIP-848. This initial PR is only adding the new APIs to all consumer classes, with support only in the async consumer.
Co-authored by: Phuc-Hong-Tran [email protected]