MINOR: Move Throttler to storage module #16023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
May 21, 2024
There was a problem hiding this comment.
@mimaison nice patch! One small comment is left. Also, could you please cleanup the spotbugs file?
kafka/gradle/spotbugs-exclude.xml
Line 495 in affe8da
| time = time) | ||
| private[log] val throttler = new Throttler(config.maxIoBytesPerSecond, | ||
| 300, | ||
| true, |
There was a problem hiding this comment.
It seems throttleDown is always true in production. Maybe we can remove it?
There was a problem hiding this comment.
Right this can be removed. Done.
I also removed the spotbugs exclusion.
|
None of the test failures seem related, merging to trunk. |
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
May 24, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Jun 1, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throttler is one of the dependencies required in order to move LogCleaner out of core.
Committer Checklist (excluded from commit message)