Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-12399: Deprecate KafkaLog4jAppender #15985

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

mimaison
Copy link
Member

As per KIP-719, KafkaLog4jAppender is now deprecated and will be removed in Kafka 4.0. Users should migrate to the log4j2 Kafka Appender

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

As per KIP-719, KafkaLog4jAppender is now deprecated and will be removed in Kafka 4.0.
Users should migrate to the log4j2 Kafka Appender
@mimaison
Copy link
Member Author

@viktorsomogyi IIRC you volunteered to do the migration work to log4j2 a while back. Are you still able/willing to do so for Kafka 4.0?

@jlprat As there's a chance 3.8 will be the last 3.X release, if we want to migrate to log4j2 in Kafka 4.0, we need to deprecate our log4j appender in 3.8.0. The KIP (KIP-719) was voted years ago, so we just need to merge this PR.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison
Copy link
Member Author

None of the test failures are related, merging to trunk

@mimaison mimaison merged commit a753172 into apache:trunk May 22, 2024
1 check failed
@mimaison mimaison deleted the kafka-12399 branch May 22, 2024 16:52
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request May 24, 2024
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Jun 1, 2024
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants