KAFKA-16288, KAFKA-16289: Fix Values convertToDecimal exception and parseString corruption #15399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tToDecimal Signed-off-by: Greg Harris <[email protected]>
… element order Signed-off-by: Greg Harris <[email protected]>
C0urante
reviewed
Feb 21, 2024
Comment on lines
+810
to
+811
| assertEquals(Type.ARRAY, schema.type()); | ||
| assertNull(schema.valueSchema()); |
There was a problem hiding this comment.
Is it too difficult to also add an assertion about the parsed values in the array? Not a blocker, but seems nice to have if possible, especially since we don't cover anything except various representations of 1 in the other test above.
|
Test failures appear unrelated, and the tests pass for me locally. |
3 tasks
testn
pushed a commit
to testn/kafka
that referenced
this pull request
Mar 15, 2024
…arseString corruption (apache#15399) * KAFKA-16288: Prevent ClassCastExceptions for strings in Values.convertToDecimal * KAFKA-16289: Values inferred schemas for map and arrays should ignore element order Signed-off-by: Greg Harris <[email protected]> Reviewers: Chris Egerton <[email protected]>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…arseString corruption (apache#15399) * KAFKA-16288: Prevent ClassCastExceptions for strings in Values.convertToDecimal * KAFKA-16289: Values inferred schemas for map and arrays should ignore element order Signed-off-by: Greg Harris <[email protected]> Reviewers: Chris Egerton <[email protected]>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
…arseString corruption (apache#15399) * KAFKA-16288: Prevent ClassCastExceptions for strings in Values.convertToDecimal * KAFKA-16289: Values inferred schemas for map and arrays should ignore element order Signed-off-by: Greg Harris <[email protected]> Reviewers: Chris Egerton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the descriptions of the tickets for full details:
These both represent breaking changes in behavior, but only when using incompatible-type arrays and maps, such as the ones included in the tests. Since the behavior of these is so opaque and silent corruption is possible with the bugs, we should change the behavior unconditionally.
Committer Checklist (excluded from commit message)