Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Update LICENSE-binary file #15322

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

mimaison
Copy link
Member

@mimaison mimaison commented Feb 6, 2024

Tested with:

$ ./gradlewAll clean releaseTarGz
$ tar xzf core/build/distributions/kafka_2.13-3.8.0-SNAPSHOT.tgz
$ cd kafka_2.13-3.8.0-SNAPSHOT/
$ for f in $(ls libs | grep -v "^kafka\|connect\|trogdor"); do if ! grep -q ${f%.*} LICENSE; then echo "${f%.*} is missing in license file"; fi; done

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @mimaison. I also checked that afterburner doesn't have any special NOTICE file different from the one we have already included

@jlprat
Copy link
Contributor

jlprat commented Feb 6, 2024

If you need to run this several times, you can try to omit the test suite, it will be faster :)

./gradlewAll clean releaseTarGz -x test

@mimaison mimaison merged commit d606818 into apache:trunk Feb 6, 2024
1 check failed
@mimaison mimaison deleted the fix-LICENSE-binary branch February 6, 2024 18:09
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants