-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Upgrade maven Artifact version to 3.9.6 #14146
Conversation
Unrelated test failures
|
One of the breaking changes in moving from 3.8.x is
@bmscomp could you please explain why we don't need to take an action to add plexus-utils explicitly? |
@divijvaidya This is an excellent review, I can see that we Gradle already grab a version 3.5.1 plexus-utils, but in the license file we refer to version 3.3.0, I need to check that subject "I did not want to say topic :) " and of course check if there is already a break regarding that version upgrade |
5281728
to
20b9b19
Compare
20b9b19
to
1dba984
Compare
@divijvaidya checked all the dependencies of the projet using the command Example of dependency tree:
Notice that the licence file is already updated to version 3.5.1, and the PR is updated So there is no need to add a separate dependency for |
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
@bmscomp Can you rebase this PR? |
8f7a8b7
to
be92ac5
Compare
@mimaison I closed the pull request by mistake, I wanted to rebase this pull request |
You should be able to reopen it. |
@mimaison Cannot find a trick to re-open this pull request, waiting to find one, I will create another one that will replace it and update the maven artifact to 3.9.6 instead of 3.9.4 |
The main motivation behind this change is to keep dependencies updated to the latest stable version of tools
used to build and publish kafka, and one of the most of important tools is maven artifact
Here is the release notes of maven artifact 3.9.4 https://maven.apache.org/docs/3.9.4/release-notes.html
One of of the big changes for this version is that java 8 is the minimum version required to use this version of maven
The build on local machine is working as perfectly, but we need to check the build on Jenkins
Committer Checklist (excluded from commit message)