Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Upgrade maven Artifact version to 3.9.6 #14146

Closed
wants to merge 0 commits into from

Conversation

bmscomp
Copy link
Contributor

@bmscomp bmscomp commented Aug 3, 2023

The main motivation behind this change is to keep dependencies updated to the latest stable version of tools
used to build and publish kafka, and one of the most of important tools is maven artifact

Here is the release notes of maven artifact 3.9.4 https://maven.apache.org/docs/3.9.4/release-notes.html

One of of the big changes for this version is that java 8 is the minimum version required to use this version of maven

The build on local machine is working as perfectly, but we need to check the build on Jenkins

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@divijvaidya
Copy link
Member

Unrelated test failures

[Build / JDK 20 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14146/1/testReport/junit/org.apache.kafka.common.network/SslTransportLayerTest/Build___JDK_20_and_Scala_2_13____3__tlsProtocol_TLSv1_3__useInlinePem_false/)
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14146/1/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_11_and_Scala_2_13___testOffsetTranslationBehindReplicationFlow__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ReplicaManagerTest.[1] enableRemoteStorage=true](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14146/1/testReport/junit/kafka.server/ReplicaManagerTest/Build___JDK_11_and_Scala_2_13____1__enableRemoteStorage_true/)
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14146/1/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_11_and_Scala_2_13___testBalancePartitionLeaders__/)
[Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicateSourceDefault()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14146/1/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest/Build___JDK_17_and_Scala_2_13___testReplicateSourceDefault__/)
[Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14146/1/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_8_and_Scala_2_12___testOffsetTranslationBehindReplicationFlow__/)

@divijvaidya
Copy link
Member

One of the breaking changes in moving from 3.8.x is

Maven 2.x was auto-injecting an ancient version of plexus-utils dependency into the plugin classpath, and Maven 3.x continued doing this to preserve backward compatibility. Starting with Maven 3.9, it does not happen anymore. This change may lead to plugin breakage. The fix for affected plugin maintainers is to explicitly declare a dependency on plexus-utils. The workaround for affected plugin users is to add this dependency to plugin dependencies until issue is fixed by the affected plugin maintainer. See [MNG-6965](https://issues.apache.org/jira/browse/MNG-6965).

@bmscomp could you please explain why we don't need to take an action to add plexus-utils explicitly?

@divijvaidya divijvaidya added the dependencies Pull requests that update a dependency file label Aug 16, 2023
@bmscomp
Copy link
Contributor Author

bmscomp commented Aug 25, 2023

@divijvaidya This is an excellent review, I can see that we Gradle already grab a version 3.5.1 plexus-utils, but in the license file we refer to version 3.3.0, I need to check that subject "I did not want to say topic :) " and of course check if there is already a break regarding that version upgrade

@bmscomp bmscomp force-pushed the upgrade/maven_artifact_version branch from 5281728 to 20b9b19 Compare August 25, 2023 22:09
@bmscomp bmscomp force-pushed the upgrade/maven_artifact_version branch from 20b9b19 to 1dba984 Compare September 10, 2023 15:40
@bmscomp
Copy link
Contributor Author

bmscomp commented Sep 10, 2023

@divijvaidya checked all the dependencies of the projet using the command ./gradlew printAllDependencies, the dependency of plexus-utils is still here but we need to update it's version in the LICENSE file

Example of dependency tree:

+--- org.apache.maven:maven-artifact:3.9.4
|    +--- org.codehaus.plexus:plexus-utils:3.5.1
|    \--- org.apache.commons:commons-lang3:3.12.0

Notice that the licence file is already updated to version 3.5.1, and the PR is updated

So there is no need to add a separate dependency for plexus-utils

Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Dec 10, 2023
@mimaison
Copy link
Member

mimaison commented Feb 2, 2024

@bmscomp Can you rebase this PR?

@bmscomp bmscomp closed this Feb 2, 2024
@bmscomp bmscomp force-pushed the upgrade/maven_artifact_version branch from 8f7a8b7 to be92ac5 Compare February 2, 2024 13:57
@bmscomp
Copy link
Contributor Author

bmscomp commented Feb 2, 2024

@mimaison I closed the pull request by mistake, I wanted to rebase this pull request

@mimaison
Copy link
Member

mimaison commented Feb 2, 2024

You should be able to reopen it.

@bmscomp
Copy link
Contributor Author

bmscomp commented Feb 2, 2024

@mimaison Cannot find a trick to re-open this pull request, waiting to find one, I will create another one that will replace it and update the maven artifact to 3.9.6 instead of 3.9.4

@bmscomp bmscomp changed the title MINOR: Upgrade maven Artifact version to 3.9.4 MINOR: Upgrade maven Artifact version to 3.9.6 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file stale Stale PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants