Skip to content

Commit

Permalink
Changed 'clients' project dependency in 'server-common' from 'impleme…
Browse files Browse the repository at this point in the history
…ntation' to 'api' to make it as a trasitive dependency as classes in 'server-common' module expose some of the 'clients' classes used.

Addressed review comments
  • Loading branch information
satishd committed May 7, 2021
1 parent 2f30822 commit 1e259ff
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,6 @@ project(':metadata') {

dependencies {
implementation project(':server-common')
implementation project(':clients')
implementation libs.jacksonDatabind
implementation libs.jacksonJDK8Datatypes
implementation libs.metrics
Expand Down Expand Up @@ -1270,13 +1269,11 @@ project(':raft') {

dependencies {
implementation project(':server-common')
implementation project(':clients')
implementation project(':metadata')
implementation libs.slf4jApi
implementation libs.jacksonDatabind

testImplementation project(':server-common')
testImplementation project(':clients')
testImplementation project(':clients').sourceSets.test.output
testImplementation libs.junitJupiter
testImplementation libs.mockitoCore
Expand Down Expand Up @@ -1353,7 +1350,7 @@ project(':server-common') {
archivesBaseName = "kafka-server-common"

dependencies {
implementation project(':clients')
api project(':clients')
implementation libs.slf4jApi

testImplementation project(':clients')
Expand Down Expand Up @@ -1645,7 +1642,6 @@ project(':shell') {
implementation libs.jline
implementation libs.slf4jApi
implementation project(':server-common')
implementation project(':clients')
implementation project(':core')
implementation project(':log4j-appender')
implementation project(':metadata')
Expand Down

0 comments on commit 1e259ff

Please sign in to comment.