Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Protect websocket url argument. #2004

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[iOS] Protect websocket url argument. #2004

merged 1 commit into from
Jan 4, 2019

Conversation

wqyfavor
Copy link
Member

@wqyfavor wqyfavor commented Jan 4, 2019

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@wqyfavor wqyfavor requested a review from YorkShen as a code owner January 4, 2019 04:25
@weex-bot
Copy link

weex-bot commented Jan 4, 2019 •
edited
Loading

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

doumafang
doumafang approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@doumafang doumafang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@doumafang doumafang merged commit 0f7a042 into apache:master Jan 4, 2019
@wqyfavor wqyfavor deleted the fix-websocket branch January 4, 2019 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@doumafang doumafang doumafang approved these changes

@YorkShen YorkShen Awaiting requested review from YorkShen YorkShen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wqyfavor @weex-bot @doumafang