Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] [Bugfix] When cell-slot contains v-if, recycle-list does not w… #1934

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

mahaiyannn
Copy link
Contributor

…ork as expected if cell is reused. The WXCellSlotComponent should be recreated when cell is reused.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

…rk as expected if cell is reused. The WXCellSlotComponent should be recreated when cell is reused.
@mahaiyannn mahaiyannn requested a review from wqyfavor as a code owner December 19, 2018 12:32
@weex-bot
Copy link

weex-bot commented Dec 19, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Member

@wqyfavor wqyfavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@wqyfavor wqyfavor merged commit 15da0c3 into apache:master Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants