Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

*[Android] interaction position for fix element #1839

Merged

Conversation

lucky-chen
Copy link
Contributor

  • for fix element ,parent is root node

so interactionAbsoluteX =

  • right : mParent.isFixed() ? cssLeft : mParent.interactionAbsoluteX + cssLeft
  • wrong: nullParent ? 0 : mParent.getAbsoluteY() + getCSSLayoutTop();

@weex-bot
Copy link

weex-bot commented Nov 28, 2018

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

@lucky-chen lucky-chen force-pushed the android-bugfix-interactionforfixelement branch from 420c7c1 to a119291 Compare November 29, 2018 03:24
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit 8780ecd into apache:master Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants