Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Fix rc 20 #1789

Merged
merged 8 commits into from
Nov 22, 2018
Merged

Fix rc 20 #1789

merged 8 commits into from
Nov 22, 2018

Conversation

wqyfavor
Copy link
Member

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

doumafang and others added 8 commits November 21, 2018 16:01
@weex-bot
Copy link

weex-bot commented Nov 21, 2018 •
edited
Loading

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@jondong
Copy link
Contributor

jondong commented Nov 22, 2018

build verified. thanks for the PR.

@jondong jondong merged commit 97eda0b into apache:rc-0.20.0 Nov 22, 2018
@wqyfavor wqyfavor deleted the fix-rc-20 branch November 23, 2018 06:40
@wqyfavor wqyfavor restored the fix-rc-20 branch November 23, 2018 06:40
@wqyfavor wqyfavor deleted the fix-rc-20 branch November 23, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wqyfavor @weex-bot @jondong @doumafang