Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Fix rc 0.20 #1786

Merged
merged 7 commits into from
Nov 21, 2018
Merged

Fix rc 0.20 #1786

merged 7 commits into from
Nov 21, 2018

Conversation

wqyfavor
Copy link
Member

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Nov 21, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@jondong
Copy link
Contributor

jondong commented Nov 21, 2018

LGTM. thanks for the PR.

@jondong jondong merged commit f060ad8 into apache:rc-0.20.0 Nov 21, 2018
@jondong jondong mentioned this pull request Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants