[KOGITO-7924] ForEach working with WorkItemHandler #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
KOGITO-7924
branch
2 times, most recently
from
0c8a6e0 to
9f0c19c
Compare
fjtirado
force-pushed
the
KOGITO-7924
branch
from
9f0c19c to
be58769
Compare
fjtirado
changed the title
fjtirado
force-pushed
the
KOGITO-7924
branch
2 times, most recently
from
e512f66 to
9a8fb2d
Compare
fjtirado
commented
Sep 14, 2022
| @@ -107,4 +114,31 @@ public static Optional<String> fallbackVarToName(String expr) { | |||
| int indexOf = expr.lastIndexOf('.'); | |||
| return indexOf < 0 ? Optional.empty() : Optional.of(expr.substring(indexOf + 1)); | |||
| } | |||
|
|
|||
| public static JsonNode addVariablesFromContext(JsonNode context, KogitoProcessContext processInfo) { | |||
There was a problem hiding this comment.
Ideally, it will be better to rather than cloning and adding the engine variables to the model being evaluated, for JQ and JsonPath to read variable value from the process instance,. if needed by the expression.
There are two problems though:
- Jq library we are using does not support that, see Change scope constructor from private to protected eiiches/jackson-jq#221
- The spec example treats the loop variable as it was part of the workflow model. This is not really true, because it should not be visible. So rather than
.itemthe expression should look$itemSee ForEach item loop variable usage in expression serverlessworkflow/specification#682
hbelmiro
approved these changes
Sep 14, 2022
...s-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/VariableInfo.java
Outdated
Show resolved
Hide resolved
...-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/ForEachRestIT.java
Outdated
Show resolved
Hide resolved
ricardozanini
approved these changes
Sep 14, 2022
|
Although not strictly related with this issue, I moved to draft because I want to add more test (in particular action data filter, I want to stress for each and I think is a good chance) |
Update quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/ForEachRestIT.java Co-authored-by: Helber Belmiro <[email protected]> Update kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/VariableInfo.java Co-authored-by: Helber Belmiro <[email protected]>
fjtirado
force-pushed
the
KOGITO-7924
branch
from
4529897 to
d823f76
Compare
fjtirado
commented
Sep 15, 2022
| "divisor" : ".divisor" | ||
| } | ||
| }, | ||
| "actionDataFilter" : { |
There was a problem hiding this comment.
Testing an actionDataFilter.
Only results manipulation make sense inside a foreach loop (result are kept in loop variable)
|
(tests) - kogito-runtimes job Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRestjava.lang.AssertionError:1 expectation failed. Expected status code <201> but was <500>. at org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest(ExpressionRestFromImageIT.java:39) org.kie.kogito.quarkus.workflows.ExpressionRestIT.testExpressionRestjava.lang.AssertionError:1 expectation failed. Expected status code <201> but was <500>. at org.kie.kogito.quarkus.workflows.ExpressionRestIT.testExpressionRest(ExpressionRestIT.java:40) |
hbelmiro
approved these changes
Sep 15, 2022
fjtirado
force-pushed
the
KOGITO-7924
branch
from
d823f76 to
11e2d27
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForEach was only working with ActionNodes. This change will allow it to work with any NodeInstance (in theory), In practise, we have either WorkItemNode or ActionNode and this is the scenario a test was added for.