Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KOGITO-4267] Kafka topic based on message name #665

Merged
merged 2 commits into from
May 13, 2021
Merged

[KOGITO-4267] Kafka topic based on message name #665

merged 2 commits into from
May 13, 2021

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Apr 23, 2021 •
edited
Loading

Adding example using multi kafka addon for Quarkus and Springboot

Merge with https://github.com/kiegroup/kogito-runtimes/pull/1235

@fjtirado fjtirado mentioned this pull request Apr 23, 2021
Merged
@kie-ci
Copy link
Contributor

kie-ci commented Apr 23, 2021

The Linux check has failed. Please check the logs.

@fjtirado fjtirado force-pushed the KOGITO-4267 branch 2 times, most recently from fefe940 to 6baa031 Compare April 26, 2021 17:12
@kie-ci
Copy link
Contributor

kie-ci commented Apr 26, 2021

The Linux check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Apr 27, 2021

The Linux check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Apr 27, 2021

The Linux check has failed. Please check the logs.

cristianonicolai
cristianonicolai reviewed May 7, 2021
View reviewed changes
@cristianonicolai cristianonicolai requested a review from radtriste May 7, 2021 07:40
@cristianonicolai
Copy link
Contributor

@fjtirado could we also add a spring based example?

@fjtirado
Copy link
Contributor Author

fjtirado commented May 7, 2021

@fjtirado could we also add a spring based example?

Hmmm, not sure about that. I was following the idea of @ricardozanini of making Quarkus first class citizen. Do we really need the springboot counterpart for all examples? This seems a good place to start saving work related with Springboot

@kie-ci
Copy link
Contributor

kie-ci commented May 7, 2021

The Linux check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented May 7, 2021

The Linux check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented May 7, 2021

The Linux check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented May 7, 2021

The Linux check has failed. Please check the logs.

@fjtirado
[KOGITO-4267] Kafka topic based on message name
7da7b1c 
Adding example using multi kafka add on
@fjtirado fjtirado marked this pull request as draft May 7, 2021 13:15
@fjtirado
Copy link
Contributor Author

fjtirado commented May 7, 2021

Adding springboot example

@fjtirado fjtirado marked this pull request as ready for review May 7, 2021 14:08
@fjtirado fjtirado requested a review from cristianonicolai May 7, 2021 14:08
@kie-ci
Copy link
Contributor

kie-ci commented May 7, 2021

The Linux check is successful.

@cristianonicolai cristianonicolai merged commit 449b9a0 into apache:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianonicolai cristianonicolai cristianonicolai approved these changes

@ibek ibek Awaiting requested review from ibek

@evacchi evacchi Awaiting requested review from evacchi

@radtriste radtriste Awaiting requested review from radtriste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fjtirado @kie-ci @cristianonicolai