Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1003] Refactored AppPaths - enforced immutability #5777

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Mar 11, 2024

Fixes apache/incubator-kie-issues#1003

This PR

  1. instantiate immutable objects to be returned by the publicly available getters
  2. uses static method to instantiate the above
  3. avoid reinstantiation of same objects at each getter invocation
  4. enforce immutability of class itself
  5. define one single object (resourcePaths) regardless of generated-resources/ bt status
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@gitgabrio
Copy link
Contributor Author

kogito-apps failure unrelated

Going to parse results form **/*-reports/TEST-*.xml
2024-03-11T10:59:24.0728205Z apache_incubator-kie-kogito-apps/data-index/data-index-service/data-index-service-mongodb/src/test/java/org/kie/kogito/index/service/graphql/MongoWebSocketSubscriptionIT.java:1 | java.util.concurrent.TimeoutException 	at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
2024-03-11T10:59:34.3143383Z apache_incubator-kie-kogito-apps/jobs-service/jobs-service-inmemory/src/test/java/org/kie/kogito/jobs/service/messaging/InMemoryMessagingApiTest.java:1 | Assertion condition defined as a org.kie.kogito.jobs.service.health.HealthCheckUtils 1 expectation failed. Expected status code <200> but was <503>.  within 1 minutes.

@gitgabrio
Copy link
Contributor Author

kogito-runtimes failure unrelated

@gitgabrio gitgabrio merged commit 6661a18 into apache:main Mar 12, 2024
8 of 9 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1003 branch March 12, 2024 10:42
@yurloc yurloc mentioned this pull request Mar 12, 2024
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Mar 27, 2024
…ty (apache#5777)

* [incubator-kie-issues#1003] Refactored AppPaths - enforced immutability

* [incubator-kie-issues#1003] Minor fix - removed unused public method (previously private)

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyze/refactor AppPaths
4 participants