rename package name `com.baidu` to `org.apache` #104

corgiboygsj · 2022-08-30T11:27:13Z

rename package name com.baidu to org.apache
upgrade version to 3.0.0

codecov · 2022-08-30T11:51:49Z

Codecov Report

Merging #104 (97d3ade) into master (42ef9c4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage     93.15%   93.15%           
  Complexity       65       65           
=========================================
  Files             9        9           
  Lines           263      263           
  Branches         22       22           
=========================================
  Hits            245      245           
  Misses            8        8           
  Partials         10       10

Impacted Files	Coverage Δ
...n/java/org/apache/hugegraph/config/RpcOptions.java	`97.22% <ø> (ø)`
...va/org/apache/hugegraph/rpc/RpcClientProvider.java	`90.90% <ø> (ø)`
...java/org/apache/hugegraph/rpc/RpcCommonConfig.java	`91.66% <ø> (ø)`
...va/org/apache/hugegraph/rpc/RpcConsumerConfig.java	`91.48% <ø> (ø)`
...in/java/org/apache/hugegraph/rpc/RpcException.java	`100.00% <ø> (ø)`
...va/org/apache/hugegraph/rpc/RpcProviderConfig.java	`100.00% <ø> (ø)`
.../main/java/org/apache/hugegraph/rpc/RpcServer.java	`92.06% <ø> (ø)`
.../apache/hugegraph/rpc/RpcServiceConfig4Client.java	`100.00% <ø> (ø)`
.../java/org/apache/hugegraph/version/RpcVersion.java	`50.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin · 2022-08-30T12:42:28Z

README.md

@@ -2,7 +2,7 @@

 [![License](https://img.shields.io/badge/license-Apache%202-0E78BA.svg)](https://www.apache.org/licenses/LICENSE-2.0.html)
 [![codecov](https://codecov.io/gh/hugegraph/hugegraph-common/branch/master/graph/badge.svg)](https://codecov.io/gh/hugegraph/hugegraph-common)
-[![Maven Central](https://maven-badges.herokuapp.com/maven-central/com.baidu.hugegraph/hugegraph-common/badge.svg)](https://mvnrepository.com/artifact/com.baidu.hugegraph/hugegraph-common)
+[![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.apache.hugegraph/hugegraph-common/badge.svg)](https://mvnrepository.com/artifact/org.apache.hugegraph/hugegraph-common)


@coderzc could u help to upload/update maven repository? (comment in pom already)

incubator-hugegraph-commons/pom.xml

Line 37 in 05e93e0

<connection>https://github.com/hugegraph/hugegraph-commons</connection>

imbajin · 2022-09-01T14:08:55Z

hugegraph-common/src/test/java/org/apache/hugegraph/unit/UnitTestSuite.java

+/*
+ * Copyright 2017 HugeGraph Authors
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hugegraph.unit;


seems this file should be treat as move a -> a' (not remove & add?)

maybe try git mv for this file

it doesn't seem to recognize that it's a file rename

it doesn't seem to recognize that it's a file rename

fix it

hugegraph-common/src/test/java/org/apache/hugegraph/unit/util/StringUtilTest.java

imbajin · 2022-09-01T14:18:03Z

style/checkstyle.xml

-        <!--        <module name="ImportOrder">-->
-        <!--            <property name="staticGroups"-->
-        <!--                      value="org.apache,java,javax,org,com,com.baidu.hugegraph"/>-->
-        <!--            <property name="separatedStaticGroups" value="true"/>-->
-        <!--            <property name="groups" value="org.apache,java,javax,org,com,com.baidu.hugegraph"/>-->
-        <!--            <property name="ordered" value="true"/>-->
-        <!--            <property name="separated" value="true"/>-->
-        <!--            <property name="option" value="top"/>-->
-        <!--            <property name="sortStaticImportsAlphabetically" value="true"/>-->
-        <!--        </module>-->


@simon824 shall we keep it & run them in ci automatically?

and could we auto format the code? (or use some mvn xxx command to check it?)

hugegraph-common/src/test/java/org/apache/hugegraph/unit/rest/RestClientTest.java

javeme · 2022-09-04T13:00:38Z

hugegraph-common/src/test/java/org/apache/hugegraph/unit/UnitTestSuite.java

+/*
+ * Copyright 2017 HugeGraph Authors
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hugegraph.unit;


it doesn't seem to recognize that it's a file rename

javeme · 2022-09-04T13:01:25Z

README.md

@@ -2,7 +2,7 @@

 [![License](https://img.shields.io/badge/license-Apache%202-0E78BA.svg)](https://www.apache.org/licenses/LICENSE-2.0.html)
 [![codecov](https://codecov.io/gh/hugegraph/hugegraph-common/branch/master/graph/badge.svg)](https://codecov.io/gh/hugegraph/hugegraph-common)
-[![Maven Central](https://maven-badges.herokuapp.com/maven-central/com.baidu.hugegraph/hugegraph-common/badge.svg)](https://mvnrepository.com/artifact/com.baidu.hugegraph/hugegraph-common)
+[![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.apache.hugegraph/hugegraph-common/badge.svg)](https://mvnrepository.com/artifact/org.apache.hugegraph/hugegraph-common)


@imbajin do we also need to rename hugegraph-common to hugegraph-commons?

seems reasonable

update version to V1.0.0 resolve conversation rollback test Update UnitTestSuite.java

corgiboygsj changed the title ~~update package name~~ rename package name com.baidu to org.apache Aug 30, 2022

corgiboygsj changed the title ~~rename package name com.baidu to org.apache~~ rename package name com.baidu to org.apache Aug 30, 2022

corgiboygsj force-pushed the update-package branch 2 times, most recently from 7d79465 to eb0d80c Compare August 30, 2022 11:48

corgiboygsj force-pushed the update-package branch 6 times, most recently from 7b5aeb1 to 39db7de Compare August 30, 2022 12:31

corgiboygsj requested review from imbajin and javeme and removed request for imbajin August 30, 2022 12:34

imbajin reviewed Aug 30, 2022

View reviewed changes

imbajin force-pushed the update-package branch from c242b1f to 05e93e0 Compare September 1, 2022 11:42

imbajin reviewed Sep 1, 2022

View reviewed changes

javeme reviewed Sep 4, 2022

View reviewed changes

corgiboygsj requested review from javeme and imbajin September 5, 2022 01:26

javeme previously approved these changes Sep 5, 2022

View reviewed changes

imbajin dismissed javeme’s stale review via edef823 September 6, 2022 04:34

imbajin force-pushed the update-package branch from 298312b to edef823 Compare September 6, 2022 04:34

update package name & set version to 1.0

3a95502

update version to V1.0.0 resolve conversation rollback test Update UnitTestSuite.java

imbajin force-pushed the update-package branch from edef823 to 3a95502 Compare September 6, 2022 04:38

Update UnitTestSuite.java

36deb79

imbajin approved these changes Sep 6, 2022

View reviewed changes

corgiboygsj requested a review from imbajin September 6, 2022 08:42

Merge branch 'master' into update-package

97d3ade

imbajin approved these changes Sep 6, 2022

View reviewed changes

corgiboygsj requested a review from imbajin September 7, 2022 07:46

imbajin requested a review from coderzc September 7, 2022 09:15

coderzc approved these changes Sep 8, 2022

View reviewed changes

coderzc merged commit 3b1bcb1 into master Sep 8, 2022

coderzc deleted the update-package branch September 8, 2022 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rename package name `com.baidu` to `org.apache` #104

rename package name `com.baidu` to `org.apache` #104

corgiboygsj commented Aug 30, 2022 •

edited

Loading

codecov bot commented Aug 30, 2022 •

edited

Loading

imbajin Aug 30, 2022 •

edited

Loading

imbajin Sep 1, 2022

javeme Sep 4, 2022

imbajin Sep 6, 2022

imbajin Sep 1, 2022

imbajin Sep 5, 2022 •

edited

Loading

javeme Sep 4, 2022

javeme Sep 4, 2022

imbajin Sep 5, 2022

rename package name com.baidu to org.apache #104

rename package name com.baidu to org.apache #104

Conversation

corgiboygsj commented Aug 30, 2022 • edited Loading

codecov bot commented Aug 30, 2022 • edited Loading

Codecov Report

imbajin Aug 30, 2022 • edited Loading

Choose a reason for hiding this comment

imbajin Sep 1, 2022

Choose a reason for hiding this comment

javeme Sep 4, 2022

Choose a reason for hiding this comment

imbajin Sep 6, 2022

Choose a reason for hiding this comment

imbajin Sep 1, 2022

Choose a reason for hiding this comment

imbajin Sep 5, 2022 • edited Loading

Choose a reason for hiding this comment

javeme Sep 4, 2022

Choose a reason for hiding this comment

javeme Sep 4, 2022

Choose a reason for hiding this comment

imbajin Sep 5, 2022

Choose a reason for hiding this comment

rename package name `com.baidu` to `org.apache` #104

rename package name `com.baidu` to `org.apache` #104

corgiboygsj commented Aug 30, 2022 •

edited

Loading

codecov bot commented Aug 30, 2022 •

edited

Loading

imbajin Aug 30, 2022 •

edited

Loading

imbajin Sep 5, 2022 •

edited

Loading