Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] Add Compatibility test found by internal #5882

Merged
merged 1 commit into from
May 28, 2024

Conversation

baibaichen
Copy link
Contributor

@baibaichen baibaichen commented May 27, 2024

What changes were proposed in this pull request?

This PR add UTs which failed at internal tests, let's fix them one by one with follow up PRs.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 947f28a into apache:main May 28, 2024
8 checks passed
@baibaichen baibaichen deleted the feature/Compatibility_testing branch May 30, 2024 02:59
@baibaichen
Copy link
Contributor Author

Releated with ClickHouse/ClickHouse#64614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants