[VL] Fallback Window operator if there is a mismatch in output type #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it spark only? if Not is it easy to fix in Velox? Can you open an issue to track in Velox? Let's merge this until it's fixed in Velox. |
|
Run Gluten Clickhouse CI |
JkSelf
changed the title
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
@FelixYBW This is a bug in velox. Fixed in facebookincubator/velox#9818 |
|
Run Gluten Clickhouse CI |
|
@JkSelf can we merge the PR? since the velox one is merged |
|
Oh, looks this one is just a workaround before velox fix. If so, let's close this one. |
|
@FelixYBW Yes. Will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fallback Window operator if there is a mismatch in output types.
How was this patch tested?
adding new unit test