[Gluten-140] Modules separate - Phase One #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzcclp
force-pushed
the
wip_module_split_1
branch
from
8ac5a1e to
bfc80fd
Compare
Separate each backend as one module, add two modules: 1. backends-clickhouse 2. backends-velox Currently, the gazelle backend and the velox backend are in one module. Use profile 'backends-clickhouse' and 'backends-velox' to compile different module when execute mvn.
zzcclp
force-pushed
the
wip_module_split_1
branch
from
bfc80fd to
573bb67
Compare
|
cc @marin-ma |
zhouyuan
approved these changes
Apr 29, 2022
|
note: velox backend passed simple test, arrow backend will be fixed in another PR |
|
Verified locally on Velox backend. |
|
note: the docs on arrow/velox backend building also needs to be updated |
I have modified some docs about mvn commands, please check and update other docs in another pr, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate each backend as one module, add two modules:
Currently, the gazelle backend and the velox backend are in one module.
Use profile 'backends-clickhouse' and 'backends-velox' to compile different module when execute mvn.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Closes #140