-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree): the symbols of image type do not display at the first rendering. close #12279. #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge some commits from apache/master
Thanks for your contribution! The pull request is marked to be |
plainheart
commented
May 15, 2020
100pah
requested changes
May 31, 2020
Looks good |
pissang
approved these changes
Jun 22, 2020
100pah
approved these changes
Jun 22, 2020
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes #12279
Fixes #11860
Fixed issues
Details
Before: What was the problem?
The symbols of image type do not display at the first rendering. Please refer to #12279, #11860 for more details.
After: How is it fixed in this PR?
After creating the instance of
SymbolClz
, update its data immediately but not wait until the next update rendering if the type of symbol is image.Related test cases
Refer to
test/tree-image2.html
for a test case.