Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): the symbols of image type do not display at the first rendering. close #12279. #12367

Merged
merged 5 commits into from
Jun 22, 2020
Merged

fix(tree): the symbols of image type do not display at the first rendering. close #12279. #12367

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6026bd3
Merge pull request #2 from apache/master
plainheart Mar 31, 2020
d11b53e
fix(tree): the symbols of image type do not display at the first rend…
plainheart Apr 2, 2020
df815b3
fix(tree): optimize code.
plainheart Apr 2, 2020
6176bd2
fix(tree): tweak access way to the type of symbolEl.
plainheart May 15, 2020
48d54d8
fix(tree): fix invalid opacity configuration for symbolPath.
plainheart May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/chart/tree/TreeView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,8 @@ function updateNode(data, dataIndex, symbolEl, group, seriesModel, seriesScope)
// Fix #12279.
// if the type of symbol is image,
// update symbol's data immediately but not wait until the next update rendering.
var symbolType = symbolEl._symbolType;
symbolType.indexOf('image://') === 0
&& symbolEl.updateData(data, dataIndex, seriesScope);
var symbolType = symbolEl.getSymbolPath().type;
symbolType === 'image' && symbolEl.updateData(data, dataIndex, seriesScope);
}
else {
symbolEl.updateData(data, dataIndex, seriesScope);
Expand Down Expand Up @@ -644,4 +643,4 @@ function getEdgeShape(seriesScope, sourceLayout, targetLayout) {
cpy2: cpy2
};

}
}