-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Calendar fix for DST #12172
Fix: Calendar fix for DST #12172
Conversation
Thanks for your contribution! |
This fix works great for us, would be nice to get this merged |
@damiangreen This PR is schedule for 4.8.0 so it will be reviewed soon. Thanks! |
Thanks @Ovilia , we're really looking forward to it |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Great! When will it hit npm? |
@damiangreen We need a few more weeks to go through Apache release progress, which usually takes about 2-4 weeks. |
@Ovilia I have checked the https://github.com/apache/incubator-echarts/commits/master/src/coord/calendar/Calendar.js |
@mikeyshing88 Thanks for your carefully check. Sorry I should have made some comment. |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes calendar chart layout when user is in a timezone with DST
Fixed issues
#12143
#10430
Details
Before: What was the problem?
When user is in a timezone with DST, the last several months of the year on the calendar chart begin to overlap eachother.
After: How is it fixed in this PR?
The fix is based on the solution from #10430
There is currently another PR attempting to fix this problem here: #12081 - however, from testing, it did not appear to correct the problem.
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information