fix bug 11677 calender （Because of DST.) #12081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
susiwen8
requested changes
Jan 18, 2020
Ovilia
requested changes
Jan 19, 2020
src/coord/calendar/Calendar.js
Outdated
| @@ -361,6 +361,7 @@ Calendar.prototype = { | |||
| * @return {Object} obj | |||
There was a problem hiding this comment.
If you wish to use show the structure of range, please do it here in the form of jsdoc.
test/calendar-fix-11677.html
Outdated
| @@ -0,0 +1,63 @@ | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
Please rename this file to be test/calendar-timezone.html because it's hard to know from the issue id directly.
| if (date.getDate() !== endDateNum) { | ||
| var sign = date.getTime() - range[1].time > 0 ? 1 : -1; | ||
| // sign记录调快还是调慢了。三月份那次， | ||
| // I only change '>' to '<'. |
There was a problem hiding this comment.
Please remove the comment of I only change '>' to '<'..
| var sign = date.getTime() - range[1].time > 0 ? 1 : -1; | ||
| // sign记录调快还是调慢了。三月份那次， | ||
| // I only change '>' to '<'. | ||
| var sign = date.getTime() - range[1].time < 0 ? 1 : -1; |
There was a problem hiding this comment.
Can you explain why you should change this? What does date.getTime() - range[1].time mean?
This was referenced Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix bug issue 11677
deal with DST.（修复个别时区存在夏令时的问题）
Fixed issues
issue 11677
Details
see the commit.
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information