Open-API: Refactor updates with discriminator #9240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generates nicer code
nastra
requested changes
Dec 7, 2023
|
Thanks @nastra for spotting! I think something went wrong with the rebase. I've updated the PR |
nastra
approved these changes
Dec 11, 2023
This was referenced Dec 11, 2023
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
* Open-API: Refactor updates with discriminator This generates nicer code * Add missing
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
* Open-API: Refactor updates with discriminator This generates nicer code * Add missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates nicer code