Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink: Backport #9078 to v1.16 and v1.15 #9151

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

cgpoh
Copy link
Contributor

@cgpoh cgpoh commented Nov 25, 2023

Backport gh-9078 to v1.16 and v1.15

@github-actions github-actions bot added the flink label Nov 25, 2023
@cgpoh cgpoh changed the title Flink: Backport gh-9078 to v1.16 and v1.15 Flink: Backport #9078 to v1.16 and v1.15 Nov 25, 2023
@cgpoh cgpoh changed the title Flink: Backport #9078 to v1.16 and v1.15 Flink: Backport [#9078](https://github.com/apache/iceberg/issues/9078) to v1.16 and v1.15 Nov 25, 2023
@cgpoh cgpoh changed the title Flink: Backport [#9078](https://github.com/apache/iceberg/issues/9078) to v1.16 and v1.15 Flink: Backport #9078 to v1.16 and v1.15 Nov 25, 2023
@pvary pvary merged commit f246614 into apache:main Nov 27, 2023
13 checks passed
@pvary
Copy link
Contributor

pvary commented Nov 27, 2023

Thanks for the backports @cgpoh!
Please when doing backport next time, tell the reviewers if it was a clean backport, or you had to change anything. This would help with the reviews!

@cgpoh: If you have time, affinity, it would be nice if you could move the other junit4 tests to junit5 too? I will be here to review them in timely manner 😄

Thanks,
Peter

@cgpoh
Copy link
Contributor Author

cgpoh commented Nov 27, 2023

Hi @pvary, thanks for the review. Just to clarify, is this PR consider clean backport?

I will try my best to move the junit 4 tests to 5 😃

@pvary
Copy link
Contributor

pvary commented Nov 27, 2023

Hi @pvary, thanks for the review. Just to clarify, is this PR consider clean backport?

If you just have to apply the Flink v1.17 changes to the v1.16, v1.15 folder, and you do not need to change anything then it is a clean backport. If you need to do some changes, because the old Flink version does not support some feature needed by the change, then it is not a clean backport

I generate the backport patches like this:

git diff HEAD^ |sed -e "s/v1.17/v1.15/g" > 1.15.patch

I will try my best to move the junit 4 tests to 5 😃

There are plenty of Flink tests which still uses junit4, so we will have tasks for a long while 😄

Thanks,
Peter

@cgpoh cgpoh deleted the backport-flinktestbase branch November 29, 2023 12:14
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants