Delta: Fix integration tests and Create DataFile by partition values instead of path #8398
+68
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
commented
Aug 26, 2023
Comment on lines
-99
to
+90
| public TestSnapshotDeltaLakeTable( | ||
| String catalogName, String implementation, Map<String, String> config) { | ||
| super(catalogName, implementation, config); | ||
| public TestSnapshotDeltaLakeTable() { | ||
| super(icebergCatalogName, SparkCatalog.class.getName(), config); |
There was a problem hiding this comment.
Junit5 cannot parametrize class creation. Since we only have one set of parameters in junit4 version, I think we can directly feed them into super class.
HonahX
commented
Aug 26, 2023
| @@ -608,6 +608,7 @@ project(':iceberg-delta-lake') { | |||
| } | |||
|
|
|||
| task integrationTest(type: Test) { | |||
| useJUnitPlatform() | |||
There was a problem hiding this comment.
The current master branch skips all the integration tests when running delta-lake CI. Seems we also need useJUnitPlatform() here when defining Junit5 integration test task.
HonahX
changed the title
HonahX
changed the title
|
@jackye1995 Could you please review this when you have a moment. Thanks in advance! |
|
Most looks good to me, CI seems to fail with unrelated issue, try to retrigger |
jackye1995
approved these changes
Dec 7, 2023
|
CI seems to be passing now after retry. Given the fact that this issue was breaking CI, I will go ahead to merge it directly. Thanks for the fix! |
This was referenced Dec 11, 2023
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withPartitionValuesintroduced in Core, Spark: Fix migrate table in case of partitioned table with partition containing a special character #7744