Spark: Fix stats in rewrite metadata action #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2022
|
Thanks for the review, @Fokko! And nice work finding the problem. |
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
rdblue
added a commit
that referenced
this pull request
Sep 3, 2022
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 9, 2023
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
* Core: Don't show dropped fields from the partition spec * Use projection instead * Use StructProjection in SparkDataFile. Co-authored-by: Fokko Driesprong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #5665. There was discussion on that PR about how to project the partition tuple to the correct final type, and this PR implements the update by passing the desired data file type into
StructDataFile. I think this is the cleanest way to fix the problem.Because
StructDataFiledoes not implementStructLikeand is instead passed into aManifestWriterthat uses theDataFileAPI, the projection can't happen inwriteManifest. InsideStructDataFile, only the partition tuple's type can differ, so only that field needs to be projected.