Core - Add MetadataUpdateParser implementation for AddPartitionSpec and AddSortOrder #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
commented
Apr 29, 2022
kbendick
commented
Apr 29, 2022
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java
Outdated
Show resolved
Hide resolved
kbendick
commented
Apr 29, 2022
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java
Outdated
Show resolved
Hide resolved
kbendick
force-pushed
the
metadata-update-serde-part-iii
branch
from
c82406f to
23ae25d
Compare
rdblue
reviewed
May 2, 2022
rdblue
reviewed
May 2, 2022
rdblue
requested changes
May 2, 2022
kbendick
force-pushed
the
metadata-update-serde-part-iii
branch
from
bb2ce44 to
33a5ab9
Compare
Removed the sorting on fields in the unbound partition spec and sort order. |
|
I removed the ordering of fields from the test. This should be good to go in maybe 10 more minutes once the last of the tests finish @rdblue. |
rdblue
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds toJson / fromJson implementations for two more implementations of
MetadataUpdate:AddPartitionSpecAddSortOrderFollowing up on PR feedback from #4632, this PR also renames the
writeAs***andreadAs***by dorpping theAsso that the functions read better. Also, the action constants have been made package-private so they can be shared with the tests.I've also placed
AddPartitionSpecinto the switch statement based on its declaration order in theMetadataUpdatefile. As it was skipped in the last PR, I moved it down so it's now moved back up.