Spark: DVs + Positional Deletes #11675
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
position-deletes-table
branch
5 times, most recently
from
a52f450 to
221a485
Compare
nastra
force-pushed
the
position-deletes-table
branch
2 times, most recently
from
283145d to
36e65b2
Compare
nastra
force-pushed
the
position-deletes-table
branch
3 times, most recently
from
782aa62 to
ffb3824
Compare
nastra
force-pushed
the
position-deletes-table
branch
from
ffb3824 to
b9adfba
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
aokolnychyi
reviewed
Jan 21, 2025
aokolnychyi
reviewed
Jan 21, 2025
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Jan 21, 2025
| Schema positionDeleteRowSchema = positionDeleteRowSchema(); | ||
| StructType deleteSparkType = deleteSparkType(); | ||
| StructType deleteSparkTypeWithoutRow = deleteSparkTypeWithoutRow(); | ||
| if (TableUtil.formatVersion(underlyingTable(table)) >= 3) { |
There was a problem hiding this comment.
I think minor compaction for DVs would look quite different from the existing logic. At the very least, we don't want to keep separate jobs per partition. I'd say we should throw an exception right now if the action is called on V3 tables until we figure out a good way to perform minor compaction for DVs.
nastra
force-pushed
the
position-deletes-table
branch
from
b9adfba to
f9f58e8
Compare
nastra
changed the title
nastra
force-pushed
the
position-deletes-table
branch
from
f9f58e8 to
27766cb
Compare
nastra
force-pushed
the
position-deletes-table
branch
from
27766cb to
67d45e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of #11122