Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename allVersions to allModules #10499

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 15, 2024

The meaning of the flag is to enable all modules. In particular, it does not enable all Scala versions for the build. The new name more directly conveys the intent.

The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
@findepi
Copy link
Member Author

findepi commented Jun 15, 2024

cc @pan3793

@nastra nastra merged commit b7a0bea into apache:main Jun 15, 2024
23 checks passed
@findepi findepi deleted the findepi/main/rename-allversions-to-allmodules-88b93f branch June 15, 2024 12:54
@findepi
Copy link
Member Author

findepi commented Jun 15, 2024

thanks for the merge, @nastra !

jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request Oct 27, 2024
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants