Spark: Don't allow branch_ usage with TIMESTAMP AS OF #10059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
approved these changes
Mar 28, 2024
singhpk234
reviewed
Mar 29, 2024
|
|
||
| // using branch_b1 in the table identifier and TIMESTAMP AS OF | ||
| Assertions.assertThatThrownBy( | ||
| () -> sql("SELECT * FROM %s.branch_b1 TIMESTAMP AS OF %s", tableName, snapshotId)) |
There was a problem hiding this comment.
[minor] should we pass actual timestamp instead of snapshotId ? though I agree this error is hit before the timestamp parsing so testing like this is also sufficient.
There was a problem hiding this comment.
Good catch @singhpk234 I totally missed this. Would be good to fix this test to pass a timestamp just so someone reading it isn't confused!
There was a problem hiding this comment.
oops that was a copy/paste error. I've changed this to using now()
nastra
force-pushed
the
branch-usage-with-timestamp-as-of
branch
from
0beaf61 to
b3b85d4
Compare
singhpk234
approved these changes
Mar 30, 2024
nk1506
pushed a commit
to nk1506/iceberg
that referenced
this pull request
Apr 2, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10058 and applies the same as #9219 for
TIMESTAMP AS OF