Scan Delete Support Part 4: Delete File Loading; Skeleton for Processing #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: only pass row groups metadata rather than entire parquet metadata to . This makes it easier to test as we don't need to mock up a full
…letes that cross page group boundaries
sdd
force-pushed
the
feat/delete-fila-manager-loading
branch
4 times, most recently
from
2ac7bca to
edb1d27
Compare
sdd
force-pushed
the
feat/delete-fila-manager-loading
branch
from
edb1d27 to
8e90bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
DeleteFileManagerintroduced in #950 To include loading of delete files, storage and retrieval of parsed delete files from shared state, and the outline for how parsing will connect up to this new work.Builds on top of #951 and #950 and should be merged after them.
Issue: #630