Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make predicate accessor functions public #1005

Merged
merged 2 commits into from
Feb 25, 2025
Merged

make predicate accessor functions public #1005

merged 2 commits into from
Feb 25, 2025

Conversation

Nathan-Fenner
Copy link
Contributor

Makes the accessor functions on UnaryExpression, BinaryExpression, and SetExpression public, making it easier to programmatically transform iceberg::expr::Predicate expressions from outside of the iceberg crate.

Closes #1003

liurenjie1024
liurenjie1024 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nathan-Fenner for this pr!

@liurenjie1024 liurenjie1024 merged commit 12b1695 into apache:main Feb 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add public accessors to BinaryExpression and SetExpression
2 participants
@Nathan-Fenner @liurenjie1024