Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [HUDI-9219] Fixing .close() calls for ClosableIterator #13034

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] [HUDI-9219] Fixing .close() calls for ClosableIterator #13034

wants to merge 2 commits into from

Conversation

vinothchandar
Copy link
Member

Change Logs

  • Added try-with-resources style handling uniformly
  • Tests and tools are the main places
  • Audited almost all of the transitive calls

Todo:

  • Bunch of FIXMEs that will eventually be resolved
  • Need to closely inspect CloseableMappingIterator usages

Impact

None

Risk level (write none, low medium or high below)

low

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@vinothchandar
[HUDI-9219] Fixing .close() calls for ClosableIterator
db6ccbc 
 - Added try-with-resources style handling uniformly
 - Tests and tools are the main places
 - Audited almost all of the transitive calls

Todo:
 - Bunch of FIXMEs that will eventually be resolved
 - Need to closely inspect CloseableMappingIterator usages
@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:L PR with lines of changes in (300, 1000]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vinothchandar