Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Detection in Text #4406 #4407

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

ep9io
Copy link
Contributor

@ep9io ep9io commented Oct 9, 2024

Adds the ability to detect the language of text inputs, via Lingua, within Apache HOP pipelines.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@ep9io ep9io changed the title [Feature Request]: Language Detection in Text #4406 Language Detection in Text #4406 Oct 10, 2024
Copy link
Contributor

@bamaer bamaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the code, ran the sample.
fixed one missing ASF header (detectlanguage.hpl), other than that code looks good.
documentation and integration tests need to be added in a separate PR.

@bamaer bamaer merged commit dbb51ae into apache:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants