Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven add the build date in the MANIFEST.MF file to complete issue #2153 #2319

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

nadment
Copy link
Contributor

@nadment nadment commented Feb 13, 2023

Specification-Version: 2.4
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)

@nadment nadment marked this pull request as draft February 14, 2023 22:27
@nadment
Copy link
Contributor Author

nadment commented Feb 14, 2023

@nadment nadment added this to the 2.4 milestone Feb 15, 2023
@nadment nadment marked this pull request as ready for review February 15, 2023 09:32
@hansva
Copy link
Contributor

hansva commented Feb 17, 2023

This will fix the URL for the development builds, but I'll have to test if it then also works with released version.

@hansva hansva self-assigned this Feb 17, 2023
@nadment
Copy link
Contributor Author

nadment commented Feb 17, 2023

You are right, use the getSpecificationVersion() method if the getImplementationVersion does not contain "SNAPSHOT"

@nadment nadment changed the title Maven add the build date in the MANFEST.MF file to complete issue #2153 Maven add the build date in the MANIFEST.MF file to complete issue #2153 Feb 18, 2023
…che#2153

Specification-Version: 2.4
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
@nadment
Copy link
Contributor Author

nadment commented Feb 18, 2023

Do not use the method getSpecificationVersion() because it contains 2.4 and not 2.4.0 and the url of the document is 2.4.0

@hansva hansva merged commit a32746f into apache:master Feb 22, 2023
@nadment nadment deleted the 2153 branch May 30, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants