Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#1931: Cleanup XML of transform Set Variable #2112

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

sramazzina
Copy link
Contributor

@sramazzina sramazzina commented Dec 29, 2022

Cleanup XML of transform Set Variable.
Some improvements on language string.
Added integration tests.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@usbrandon usbrandon marked this pull request as draft December 30, 2022 15:12
@hansva
Copy link
Contributor

hansva commented Jan 2, 2023

@usbrandon , what is the reason for marking it as a draft?

@sramazzina
Copy link
Contributor Author

sramazzina commented Jan 3, 2023

Brandon noticed that there are some imports that could be optimized. I didn't noticed that and I agree with him. I will take care about that today. I asked him to mark the PR as draft because I was on holiday and he kindly did it.

@hansva
Copy link
Contributor

hansva commented Jan 3, 2023

Alright, I was just wondering as there was no discussion or reason here as to why it was changed to draft.

@sramazzina sramazzina marked this pull request as ready for review January 5, 2023 07:49
@hansva hansva self-requested a review January 19, 2023 08:45
@hansva hansva merged commit 117a394 into apache:master Jan 19, 2023
@sramazzina sramazzina deleted the 1931 branch January 26, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants