[Bug]: MetaInject step not correctly imported from Kettle

[nadment]

Apache Hop version?

2.10.0-SNAPSHOT

Java version?

Java 17

Operating system

Windows

What happened?

MetaInject step file name not correctly imported from Kettle. You need to combine 'directory_path' and 'trans_name' to build the filename.

We also need to set the default Run configuration.

  <step>
    <name>ETL Metadata Injection</name>
    <type>MetaInject</type>
    <trans_name>PIPELINE_NAME</trans_name>
    <filename />
    <directory_path>/PATH_TO_IMPORT</directory_path>

Code to rebuild file name, same logic than MAPPING

      if (entryType == EntryType.METAINJECT && currentNode.getNodeName().equals("transform")) {
        Node filenameNode = null;
        String transName = "";
        String directoryPath = "";
        // get trans name, file name, path, set correct filename when needed.
        for (int j = 0; j < currentNode.getChildNodes().getLength(); j++) {
          if (currentNode.getChildNodes().item(j).getNodeName().equals("directory_path")) {
            directoryPath = currentNode.getChildNodes().item(j).getTextContent();
            currentNode.removeChild(currentNode.getChildNodes().item(j));
          }
          if (currentNode.getChildNodes().item(j).getNodeName().equals("trans_name")) {
            transName = currentNode.getChildNodes().item(j).getTextContent();
            currentNode.removeChild(currentNode.getChildNodes().item(j));
          }
          if (currentNode.getChildNodes().item(j).getNodeName().equals("filename")) {
            filenameNode = currentNode.getChildNodes().item(j);
          }
        }

        // if we have a trans name and directory path, use it to update the pipeline
        // filename.
        if (!StringUtils.isEmpty(transName) && !StringUtils.isEmpty(directoryPath)) {
          filenameNode.setTextContent("${PROJECT_HOME}" + directoryPath + '/' + transName + ".hpl");
        }

        // add the default pipeline run configuration.
        Element runConfigElement = doc.createElement("runConfiguration");
        runConfigElement.appendChild(doc.createTextNode(defaultPipelineRunConfiguration));
        currentNode.appendChild(runConfigElement);
      }

Issue Priority

Priority: 3

Issue Component

Component: Import