Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Rest Transform Timeout #3811

Closed
marwari8 opened this issue Apr 15, 2024 · 3 comments · Fixed by #3913
Closed

[Feature Request]: Rest Transform Timeout #3811

marwari8 opened this issue Apr 15, 2024 · 3 comments · Fixed by #3913
Assignees
@nadment
Labels
new feature P2 Default Priority Transforms
Milestone
2.9

Comments

@marwari8
Copy link

What would you like to happen?

Observed
Currently calling a rest transform that takes too much time will quicky abort the process due to a hardcoded timeout value.
the timeout is currently hardcooded in ApacheHop, Bart Maerens confirmed on Mon 26/02/2024 20:28 that this is not yet possible (thanks for the quick confirmation)

Expected
Allow to specify a timeout in the rest transform.
maybe as a quick and dirty (interim) solution : allow to set a global parameter for all rest transform (you will not need to change the UI)

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui, Component: Hop Server, Component: Hop Web
@marwari8 marwari8 changed the title [Feature Request]: [Feature Request]: Rest Transform Timeout Apr 15, 2024
@nadment nadment self-assigned this May 7, 2024
nadment added a commit to nadment/hop that referenced this issue May 7, 2024
@nadment
Add connection timeout and read timeout to Rest transform apache#3811
9274637 
Fix Http transform connection timeout (confusion with socket timeout)
@nadment
Copy link
Contributor

nadment commented May 7, 2024

I'm going to add two timeout possibilities, for the connection and for reading data.
image

nadment added a commit to nadment/hop that referenced this issue May 7, 2024
@nadment
Add connection timeout and read timeout to Rest transform apache#3811
912b413 
Fix Http transform connection timeout (confusion with socket timeout)
nadment added a commit to nadment/hop that referenced this issue May 7, 2024
@nadment
Add connection timeout and read timeout to Rest transform apache#3811
bc6b140 
Fix Http transform connection timeout (confusion with socket timeout)
@nadment nadment linked a pull request May 7, 2024 that will close this issue
Add connection timeout and read timeout to Rest transform #3811 #3913
Merged
@hansva
Copy link
Contributor

hansva commented May 7, 2024

@nadment maybe we should add an indicator to the label. is that timeout in seconds? milliseconds?

nadment added a commit to nadment/hop that referenced this issue May 7, 2024
@nadment
Add connection timeout and read timeout to Rest transform apache#3811
5007ab9 
Fix Http transform connection timeout (confusion with socket timeout)
@nadment
Copy link
Contributor

nadment commented May 7, 2024

I've added the indication and updated the document too.

hansva added a commit that referenced this issue May 8, 2024
@hansva
Merge pull request #3913 from nadment/3811
4394fb3 
Add connection timeout and read timeout to Rest transform #3811
@hansva hansva added this to the 2.9 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
new feature P2 Default Priority Transforms
Projects
None yet
Milestone
2.9
Development

Successfully merging a pull request may close this issue.

Add connection timeout and read timeout to Rest transform #3811 nadment/hop
3 participants
@hansva @nadment @marwari8