Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Multiway merge join - join keys combo box duplicates key fields #3584

Closed
joshdowning opened this issue Jan 27, 2024 · 2 comments
Closed

[Bug]: Multiway merge join - join keys combo box duplicates key fields #3584

joshdowning opened this issue Jan 27, 2024 · 2 comments
Assignees
@joshdowning
Labels
bug P3 Nice to have Transforms
Milestone
2.8

Comments

@joshdowning
Copy link
Contributor

Apache Hop version?

2.8.0-SNAPSHOT

Java version?

11

Operating system

Windows

What happened?

Small bug that was annoying me so I fixed it locally. Each time you hit ok and reopen the combo box, the input keys are duplicated (gets really messy when you have lots of input keys) See image below. Key fields should only show id and name once.
image

Issue Priority

Priority: 3

Issue Component

Component: Transforms
@joshdowning
Copy link
Contributor Author

joshdowning commented Jan 27, 2024 •
edited
Loading

.take-issue

@github-actions github-actions bot added P3 Nice to have Transforms labels Jan 27, 2024
joshdowning pushed a commit to joshdowning/hop that referenced this issue Jan 28, 2024
apache#3584 duplicated and wrong join keys showing in combobox
e38b313
joshdowning pushed a commit to joshdowning/hop that referenced this issue Jan 28, 2024
fix duplicate and wrong keys in multiway merge join combobox apache#3584
3e1df76
joshdowning added a commit to joshdowning/hop that referenced this issue Jan 28, 2024
@joshdowning
fix duplicate and wrong keys in multiway merge join combobox apache#3584
ddc4cef
@joshdowning joshdowning mentioned this issue Jan 28, 2024
Merged
5 tasks
@bamaer
Copy link
Contributor

bamaer commented Jan 28, 2024

thanks @joshdowning, we'd love to see your pull request when you're ready.
Small fixes like these help tremendously to make Hop better!

hansva added a commit that referenced this issue Jan 29, 2024
@hansva
Merge pull request #3585 from joshdowning/3584
80d4a58 
fix duplicate and wrong keys in multiway merge join combobox #3584
@hansva hansva added this to the 2.8 milestone Jan 29, 2024
@hansva hansva closed this as completed Jan 29, 2024
bamaer pushed a commit to bamaer/hop that referenced this issue Feb 24, 2024
@joshdowning @bamaer
fix duplicate and wrong keys in multiway merge join combobox apache#3584
fedb24c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdowning joshdowning

Labels
bug P3 Nice to have Transforms
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@bamaer @hansva @joshdowning